The following document contains the results of PMD 4.3.
| Violation | Line |
|---|---|
| Document empty constructor | 35 |
| The field name indicates a constant but its modifiers do not | 43 |
| Variables should start with a lowercase character | 43 |
| The field name indicates a constant but its modifiers do not | 45 |
| Variables should start with a lowercase character | 45 |
| Violation | Line |
|---|---|
| Too many static imports may lead to messy code | 22 - 223 |
| This class has too many methods, consider refactoring it. | 53 - 223 |
| The class 'VmTruckLoader' has a Cyclomatic Complexity of 3 (Highest = 11). | 53 - 223 |
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 53 - 223 |
| A catch statement should never catch throwable since it includes errors. | 67 |
| System.exit() should not be used in J2EE/JEE apps | 71 |
| The method 'run' has a Cyclomatic Complexity of 11. | 75 - 139 |
| Local variable 'arguments' could be declared final | 76 |
| Local variable 'props' could be declared final | 86 |
| Local variable 'weld' could be declared final | 90 |
| Local variable 'machineService' could be declared final | 91 |
| System.exit() should not be used in J2EE/JEE apps | 96 |
| Local variable 'lines' could be declared final | 166 |
| Local variable 'specs' could be declared final | 167 |
| Local variable 'arguments' could be declared final | 201 |
| System.exit() should not be used in J2EE/JEE apps | 208 |
| System.exit() should not be used in J2EE/JEE apps | 214 |
| System.out.print is used | 218 |
| System.exit() should not be used in J2EE/JEE apps | 219 |
| Violation | Line |
|---|---|
| Local variable 'entries' could be declared final | 86 |
| Local variable 'writer' could be declared final | 88 |
| Local variable 'strategy' could be declared final | 102 |
| Local variable 'columns' could be declared final | 104 |
| Local variable 'csv' could be declared final | 107 |
| Local variable 'list' could be declared final | 108 |
| Violation | Line |
|---|---|
| Local variable 'fileEncoding' could be declared final | 73 |
| Local variable 'fileEncoding' could be declared final | 87 |
| Local variable 'text' could be declared final | 88 |
| Local variable 'fileEncoding' could be declared final | 118 |
| Local variable 'lines' could be declared final | 119 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 42 - 79 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 41 - 107 |
| Local variable 'vmSpec' could be declared final | 49 |
| Local variable 'ethernet' could be declared final | 56 |
| Local variable 'nicSpec' could be declared final | 64 |
| Local variable 'nic' could be declared final | 67 |
| Local variable 'nicBacking' could be declared final | 68 |
| Local variable 'info' could be declared final | 71 |
| Local variable 'vmSpec' could be declared final | 87 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 44 - 191 |
| Local variable 'managedEntities' could be declared final | 51 |
| Avoid printStackTrace(); use a logger call instead. | 58 |
| Local variable 'managedEntities' could be declared final | 66 |
| Local variable 'inventoryNavigator' could be declared final | 69 |
| Avoid printStackTrace(); use a logger call instead. | 74 |
| Local variable 'pools' could be declared final | 82 |
| Local variable 'pool' could be declared final | 85 |
| Local variable 'folders' could be declared final | 95 |
| Prefer StringBuffer over += for concatenating strings | 99 |
| Deeply nested if..then statements are hard to read | 142 - 146 |
| Avoid printStackTrace(); use a logger call instead. | 170 |
| Local variable 'rootFolder' could be declared final | 180 |
| Local variable 'inventoryNavigator' could be declared final | 181 |
| Local variable 'errorMessage' could be declared final | 185 |
| Violation | Line |
|---|---|
| The class 'AbstractVMWareActionCallback' has a Cyclomatic Complexity of 8 (Highest = 13). | 45 - 89 |
| The method 'runTask' has a Cyclomatic Complexity of 13. | 49 - 83 |
| Local variable 'status' could be declared final | 53 |
| Local variable 'info' could be declared final | 55 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 59 - 62 |
| Local variable 'relocateSpec' could be declared final | 65 |
| Local variable 'pool' could be declared final | 68 |
| Local variable 'store' could be declared final | 75 |
| Local variable 'nic' could be declared final | 96 |
| Avoid instantiating new objects inside loops | 97 |
| Local variable 'nicSpec' could be declared final | 97 |
| Local variable 'relocateSpec' could be declared final | 107 |
| Local variable 'cloneSpec' could be declared final | 109 |
| Local variable 'sourceVm' could be declared final | 115 |
| Local variable 'setupFolder' could be declared final | 120 |
| Local variable 'status' could be declared final | 126 |
| Local variable 'errorMessage' could be declared final | 137 - 138 |
| Violation | Line |
|---|---|
| The class 'EditMachineCallback' has a Cyclomatic Complexity of 5 (Highest = 14). | 54 - 120 |
| It is a good practice to call super() in a constructor | 60 - 62 |
| Use equals() to compare strings instead of '==' or '!=' | 73 |
| The method 'runTask' has a Cyclomatic Complexity of 14. | 88 - 119 |
| Local variable 'task' could be declared final | 90 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 22 - 197 |
| Local variable 'networkNameEncoded' could be declared final | 174 |
| System.out.print is used | 175 |
| Local variable 'switches' could be declared final | 176 |
| Local variable 'switchList' could be declared final | 177 |
| Local variable 'sw' could be declared final | 179 |
| System.out.print is used | 181 |
| Local variable 'managedEntities' could be declared final | 184 |
| Local variable 'g' could be declared final | 186 |
| Local variable 'switchKey' could be declared final | 188 |
| Local variable 'sw' could be declared final | 189 |
| System.out.print is used | 190 |